fix: update nodejs version

UMAprotocol / protocol

UMA Protocol Running on Ethereum

https://uma.xyz

GNU Affero General Public License v3.0

361 stars 175 forks source link

fix: update nodejs version #4678

Closed mrice32 closed 6 months ago

mrice32 commented 6 months ago

Motivation

Nodejs 16 is EOL and it's important to continue to get security updates from nodejs.

Summary

Updated all references to nodejs 16.

Testing

Check a box to describe how you tested these changes and list the steps for reviewers to test.

[ ] Ran end-to-end test, running the code as in production
[ ] New unit tests created
[x] Existing tests adequate, no new tests required
[ ] All existing tests pass
[ ] Untested

Issue(s)

N/A

mrice32 commented 6 months ago

Reason to not fix it to a version? Otherwise lgtm

There is no alias for cimg/node:20 AFAICT (https://circleci.com/developer/images/image/cimg/node), sadly. We could do cimg/node:20.10, but it would be nice to automatically pull in minor version bumps in case a security update is a minor version.

Thoughts? Would you prefer a pin to 20.10?

daywiss commented 6 months ago

i think down the road we may be debugging CI because it broke due to major node version bump, but like u mentioned there is a tradeoff for that. not a blocker either way!