search

UMB-CS-682-Team-03 / tracker

0 stars 0 forks source link

Fix translation all words #64

Closed patel-malav closed 4 months ago

rouilj commented 4 months ago

Except for the doc issue looks good to me.

patel-malav commented 4 months ago

@rouilj um doc issues.

you mean should I not have included that section or just refer them to roundup docs for translation?

rouilj commented 4 months ago

Including the section is fine Especially since the translation strings can't be automatically extracted by roundup-gettext.

I think your example is wrong. I don't think:

msgid "Next"
msgstr "nächste"

is going to work. When you set up: `` const CLASSHELPER_TRANSLATION_KEYWORDS = ["apply", "cancel", "next", "prev", "search", "reset"];

you changed "Next" to "next". I think the docs have to change to:

msgid "next" msgstr "nächste"

patel-malav commented 4 months ago

@rouilj Fixed the docs and added warning for case sensitive msgid

Merging it into main