search

UMB-CS-682-Team-03 / tracker

0 stars 0 forks source link

Cancel button in popup is generating valueSelected event #85

Closed rouilj closed 5 months ago

rouilj commented 5 months ago

as a result the value is being overwritten in the main window.

See: https://github.com/UMB-CS-682-Team-03/tracker/blob/dad66fe6506aaa1d213bd97fd45f2904a5e00388/html/classhelper.js#L742-L750

I think the right thing to do here @malav is this.popupRef.close() right? Is there any reason to generate a custom close event?

rouilj commented 5 months ago

I committed a fix that seems to work. When Malav has some free time in a few days he can review and fix if needed.