search

UMBC-CMSC447-Spring2017-Team5 / college-JUMP

https://lassa.xen.prgmr.com/collegejump/
GNU General Public License v3.0
0 stars 0 forks source link

Lowercase emails in all places #52

Closed alexander-bauer closed 7 years ago

alexander-bauer commented 7 years ago

Currently, emails in different cases will not match. We should make them lowercase everywhere, as is standard.

alexander-bauer commented 7 years ago

@UMBC-CMSC447-Spring2017-Team5/developers This is also probably pretty easy.

Mjacks3 commented 7 years ago

All of two places in the views should be all that's needed, right? Account creation and login? Reopen if needed.

alexander-bauer commented 7 years ago

@Mjacks3 I think it might be worth building this into the User model, since we might wind up with new ways to create users that would be missed by this, like with the database import. (Admittedly, as long as the data we export is good, that shouldn't be a problem.) There's probably an easy way to do it.

Mjacks3 commented 7 years ago

Sure. As a heads up, tomorrow I'm gonna need some help switching over to Linux development in order to continue working on issues. My windows environment seems stuck in previous versions, or for whatever reason, just fails to catch up with updates.

alexander-bauer commented 7 years ago

I'm going to mark this as an enhancement, since it'd be a nice-to-have, but not something we need to look too hard into right now.

Mjacks3 commented 7 years ago

Notes: move user creation email from inside constructor to outside constructor