search

UMD-AOSC / UMD-SST

Testbed sea surface analysis system
Apache License 2.0
1 stars 2 forks source link

Use land mask when initializing bump #40

Closed travissluka closed 3 years ago

travissluka commented 3 years ago

use the land mask when initializing BUMP horizontal convolution.

travissluka commented 3 years ago

Add to the staticbinit, var, and dirac: mask_check: 1 network: 1

loganchen39 commented 3 years ago

@travissluka The staticbinit failed the test after adding these two items, I'll check.

travissluka commented 3 years ago

you'll have to delete the previous output files that were generated by staticbinit. If the size of the files changes (which they are, because we have fewer gridpoints now with a mask) BUMP will complain and crash

On Tue, Feb 9, 2021 at 8:24 AM Logan (Ligang) Chen notifications@github.com wrote:

@travissluka https://github.com/travissluka The staticbinit failed the test after adding these two items, I'll check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/UMD-AOSC/UMD-SST/issues/40#issuecomment-776020739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7PW2JG5VJH3HIOQRVNEUDS6FHUVANCNFSM4USOEKWQ .

-- Travis Sluka Software Engineer | Joint Center for Satellite Data Assimilation, UCAR Boulder, CO

loganchen39 commented 3 years ago

Yes I deleted all the files first, it generated all of the netCDF files which look ok, but it failed the tests for staticbinit, dirac and var. I'll check.