UMD-AOSC / UMD-SST

Testbed sea surface analysis system
Apache License 2.0
1 stars 2 forks source link

Don't do C/K conversion on read/write for Increment #44

Closed travissluka closed 3 years ago

travissluka commented 3 years ago

The Field::read() and Field::write() are converting to/from Kelvin so that the value inside jedi is in Celsius, however this means the saved/read Increment files are wrong (as exposed by PR https://github.com/UMD-AOSC/UMD-SST/pull/43). This isn't a huge problem now, but will make interpreting dirac output awkward in the future.

The easiest solution is probably to add a kelvin: true line to the appropriate state I/O sections of the yaml files and check inside Field::read() and Field::write() if that parameter exists, and only do the conversion if that parameter exists and is true.