search

UMD-AOSC / UMD-SST

Testbed sea surface analysis system
Apache License 2.0
1 stars 2 forks source link

Feature/add mask field #51

Closed loganchen39 closed 3 years ago

loganchen39 commented 3 years ago

@travissluka passed all test. I used the background file of "19850101_regridded_sst.nc" to create the landmask.nc, so they should be consistent.

Close #38 .

travissluka commented 3 years ago

It would also be very useful to print the number of masked and unmasked points in Geometry::print()

travissluka commented 3 years ago

I just double checked with the SOCA code, and the mask should be inverted. 1= ocean, 0=land. BUMP will expect 1 for the gridpoints that we want to used.

loganchen39 commented 3 years ago

Ok, will update accordingly. Thanks,

loganchen39 commented 3 years ago

@travissluka I have updated accordingly. Please continue the CI check and merge the code if it's ok. Got distracted from the work.

travissluka commented 3 years ago

staticbinit is no longer passing, something apparently changed in saber that I missed. I'll try to fix that first

loganchen39 commented 3 years ago

@travissluka I've added your code from #52 , and it passes all tests. Please merge for now, and we'll update the code in the future if needed. Close #52 .