get a better landmask - Githubissues

UMD-AOSC / UMD-SST

Testbed sea surface analysis system

Apache License 2.0

1 stars 2 forks source link

get a better landmask #61

Closed travissluka closed 3 years ago

travissluka commented 3 years ago

Replace landmask file with a better one (mainly fixing Central America).
make sure there are observations in the dirac test that are near Panama so that the network check on the land mask can be properly tested.

loganchen39 commented 3 years ago

@travissluka I uploaded an improved landmask.nc then the test of test_umdsst_staticbinit failed due to "Level 1: 0% 5% 10% 15% 20% 25% 30% 35% 40% 45% 50% 55% 60%!!! ABORT in mpl_nc_dim_define_or_get on task #0002: dimension nc1b has a different size in file". Those files that have "nc1b" are bump/bump_sst_nicas_000002-000001.nc and bump/bump_sst_nicas_000002-000002.nc, and the nc1b values in these two files are 1049 and 841 respectively.

If I use the original landmask, all of the tests can pass. What might be the problem?

loganchen39 commented 3 years ago

@travissluka The improved landmask is at the feature/betterLandmask branch.

travissluka commented 3 years ago

oops, I had said the bump files should be deleted before staticbinit is run, but it turns out i forgot the rm -f $f line after https://github.com/UMD-AOSC/UMD-SST/blob/89c45319844aaa3e05c47732832816232d9441dd/test/test_wrapper.sh#L13, so the files are not actually being deleted. If you fix that it might fix the problem.

I'm away from home this week, but I can take a closer look when I get back tuesday.

travissluka commented 3 years ago

closed by https://github.com/UMD-AOSC/UMD-SST/pull/63