search

UMD-AOSC / UMD-SST

Testbed sea surface analysis system
Apache License 2.0
1 stars 2 forks source link

Feature/experiment - Added some initial background of 0.25x0.25 grid. #77

Closed loganchen39 closed 3 years ago

loganchen39 commented 3 years ago

@travissluka I haven't combined your latest PR of "#76 support for modules with new ecbuild", hope there won't be any conflict.

Close #72 .

travissluka commented 3 years ago

could you please rename the files so that it is clear which ones are 1/4 deg and which ones are 1 deg

loganchen39 commented 3 years ago

could you please rename the files so that it is clear which ones are 1/4 deg and which ones are 1 deg

I just renamed these files. Hopefully now it's ok.

loganchen39 commented 3 years ago

It's not passing the test, I'll update the latest develop branch and re-commit again.

travissluka commented 3 years ago

@loganchen39 the tests are failing because you renamed the files but you didn't change names of those files inside the test/testinput/ yaml files

loganchen39 commented 3 years ago

@travissluka After combining your latest develop to my working feature/experiment branch, it failed to compile, gonna take a while to figure it out. Previously I tried to use latest ecbuild on Cheyenne and had problems with compiling.

travissluka commented 3 years ago

you haven't updated this file https://github.com/UMD-AOSC/UMD-SST/blob/bd98627119235e740ff817ea5b136a174274f761/test/CMakeLists.txt#L23

That previous PR should work for either the new ecbuild or the current. Please test these out when I issue the PRs, part of the reason for getting your approval is to make sure things work for you.