UMDBPP / Balloonduino

Library for basic functions of Balloonduino (Arduino Mega with onboard sensors)
MIT License
3 stars 0 forks source link

prototype balloonduino library #27

Closed zacharyburnett closed 6 years ago

zacharyburnett commented 6 years ago

DONE

TODO

  1. test it
  2. general xbee functions
  3. refactor with verbosity and document for future users / developers
nmrossomando commented 6 years ago

Macros are handled in compilation, so they can't be user settable. You could move to globals, but that's also not a wonderful solution since it's possible to accidentally reassign them. #ifndefs are a decent solution but definitely do need to be commented to the functionality is understood/the user knows how to change them.

Another possible solution is a global class which protects the variables, so you do something like XBee_vars.set(val) to set it and XBee_vars.get(val) to use the value, so there's no way for an accidental reset.

Hope y'all don't mind me throwing in my two cents, as I still get the Github emails :P

zacharyburnett commented 6 years ago

I changed the #defines to global bools and added a bunch of params to begin()

zacharyburnett commented 6 years ago

pulling current changes into master to work on new problem in develop