search

UMDLARS / one_night_in_sf

A story game demonstrating why physical security is important and complex!
2 stars 2 forks source link

Some doors can be picked up #146

Closed Saturn-99 closed 10 months ago

Saturn-99 commented 1 year ago

Door to Len's office can be picked up by player and walked off with. While it is in their inventory it still claims the door blocks the path north there too.

pahp commented 1 year ago

That's trippy.

spacehobo commented 1 year ago

Hm, I wonder if we should switch that to use Simple Doors. Anyway, it's worth putting a failing test in a branch so we can work on the fix iteratively.

spacehobo commented 1 year ago

Oh, we do use Simple Doors here. And I can't seem to reproduce this in a test. Do we have transcripts of people doing this?

https://github.com/UMDLARS/one_night_in_sf/commit/5e642e495762ca06c00712a7230ed2c8e584e940

Try pulling the issue146 branch and running make. It doesn't seem to happen.

spacehobo commented 10 months ago

In issue 175, I noticed that the tests assume this door is movable, while it seems to actually be static. Did we perhaps fix this already, but missed that because the tests weren't kept up?

Saturn-99 commented 10 months ago

Hmm yeah I think this issue got fixed and some how the issue didn't get closed.

Saturn-99 commented 10 months ago

Ah yeah, I remember now. It used to be that the door had to be moved after the hinges were removed but we felt that was needlessly tedious so now the door just falls when you remove the hinges (which is probably pretty realistic). That must have unwittingly fixed this issue. @spacehobo