Fixes #222: "Make flathead too big for phillips screws"

UMDLARS / one_night_in_sf

A story game demonstrating why physical security is important and complex!

2 stars 2 forks source link

Fixes #222: "Make flathead too big for phillips screws" #265

Closed libraun closed 1 month ago

libraun commented 1 month ago

Added check to prevent player from trying to unscrew Ellie's computer with a flathead screwdriver (in which case it prints a minor hint and returns false);
Adjusted header test '_ready coffee card' to also pick up flathead screwdriver, to test unscrewing ellie's computer;
Added tests where the player attempts to unlock ellie's computer using both the flathead screwdriver and the phillips head screwdriver, using various acceptable phrases.

pahp commented 1 month ago

Here's a transcript of me trying:

> open ellie's computer with flathead
You try to unscrew the screws with your flathead screwdriver, but it does not fit.You can't
unlock that.

> unlock ellie's computer with flathead
You try to unscrew the screws with your flathead screwdriver, but it does not fit.You can't
unlock that.

> unlock computer with flathead
You try to unscrew the screws with your flathead screwdriver, but it does not fit.You can't
unlock that.

>

I think it would be better if it said something like:

"... it does not fit because the screws are Phillips head screws."

Can we suppress the "You can't unlock that." message? If so, please do.

If it must be there, it should have a space after the period.

spacehobo commented 1 month ago

Can we suppress the "You can't unlock that." message? If so, please do.

If it must be there, it should have a space after the period.

We can absolutely do this by overriding the after response in this same situation. In fact, a more state-aware problem like this one is the first reader exercise in the DM4 (answer here).

pahp commented 1 month ago

Hey @libraun or @spacehobo -- can you give this a peek? You'll need to resolve the conflict for the new strings about Ellie's computer. (I have removed 'return false' per Spacehobo's suggestion.)

libraun commented 1 month ago

Yes!

On Tue, Sep 24, 2024 at 3:41 PM Peter A. H. Peterson < @.***> wrote:

Hey @libraun https://github.com/libraun or @spacehobo https://github.com/spacehobo -- can you give this a peek? You'll need to resolve the conflict for the new strings about Ellie's computer. (I have removed 'return false' per Spacehobo's suggestion.)

— Reply to this email directly, view it on GitHub https://github.com/UMDLARS/one_night_in_sf/pull/265#issuecomment-2372345375, or unsubscribe https://github.com/notifications/unsubscribe-auth/APBM67IPXR6LTHBO6SJRZ33ZYHE55AVCNFSM6AAAAABOW2IVSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZSGM2DKMZXGU . You are receiving this because you were mentioned.Message ID: @.***>