fix the goto part in snow code

UMEP-dev / SUEWS

Surface Urban Energy and Water Balance Scheme

https://suews.readthedocs.io/

Mozilla Public License 2.0

12 stars 8 forks source link

fix the goto part in snow code #128

Closed sunt05 closed 5 months ago

sunt05 commented 2 years ago

discussed with @ljarvi: this should be fixed.

https://github.com/UMEP-dev/SUEWS/blob/37da3415d54fbdec9098727a6e6b0d9a91f7d0c2/SUEWS-SourceCode/src/suews_phys_snow.f95#L718

ljarvi commented 1 year ago

Hi. I'm currently working on the snow module to fix this "go to"-issue, but when doing this I noticed several issues in modelling snow. SWE in the main 60-min output file is not currently printed out (SWE for different surfaces are printed out in the snow output file, not sure where the issue is again as it is not in the snow module but rather in printing out). Also SMD is not updated when snow is on, which I need to understand why is this.

sunt05 commented 11 months ago

related #135 #231

sunt05 commented 5 months ago

fixed in https://github.com/UMEP-dev/SUEWS/commit/336cad07c08de8a6f9d3a3fd7cfe5d44b02ff1ec