UMEP-dev / SUEWS

Surface Urban Energy and Water Balance Scheme
https://suews.readthedocs.io/
Mozilla Public License 2.0
12 stars 8 forks source link

EPW issues #152

Open sunt05 opened 3 years ago

sunt05 commented 3 years ago

Thanks for reporting this. I'll see how a fix can be made.

Please consider the EPW-related functionality as experimental and avoid using them in your "decent" research/work at the moment: please use with caution but feedbacks are more than welcome 🤝

Originally posted by @sunt05 in https://github.com/UMEP-dev/UMEP/issues/219#issuecomment-762165947

tyhzxc commented 3 years ago

information about epw file header EnergyPlus Weather File (EPW) Data Dictionary https://bigladdersoftware.com/epx/docs/8-3/auxiliary-programs/energyplus-weather-file-epw-data-dictionary.html

current header

    text_meta = """
LOCATION,Chongqing Shapingba,Chongqing,CHN,CSWD,575160,29.58,106.47,8,259.1
DESIGN CONDITIONS,0
TYPICAL/EXTREME PERIODS,0
GROUND TEMPERATURES,3,.5,,,,13.31,10.23,9.39,10.12,14.28,18.95,23.34,26.51,27.44,25.95,22.35,17.82,2,,,,16.09,13.20,11.82,11.77,13.97,17.16,20.59,23.54,25.06,24.77,22.74,19.63,4,,,,17.90,15.65,14.27,13.85,14.66,16.52,18.83,21.09,22.62,22.98,22.11,20.29
HOLIDAYS/DAYLIGHT SAVINGS,No,0,0,0
COMMENTS 1, generated by SuPy
COMMENTS 2, none
DATA PERIODS,1,1,Data,Sunday,1/1,12/31
    """
biglimp commented 2 years ago

I have missed this. The EWP files does not have continuous time steps as months are taken from different years. In order to make use of epw-files in e.g. SUEWS I just took on year (1985) as a base. If that is not appropriate, I can change so that the actual years in the EPW file is kept. Let me know how you would like it.

sunt05 commented 2 years ago

@biglimp I'll handle this in the SuPy project: delayed for a while, sorry guys.

biglimp commented 2 years ago

Ok, but I override the year in https://github.com/UMEP-dev/UMEP/blob/SuPy-QGIS3/MetdataProcessor/metdata_processor.py#L259. Just let me know If I should keep this or not.

sunt05 commented 2 years ago

that should be file: years have no effect in the actual calculations.