QE, QH T2 results lost in certain conditions

UMEP-dev / SUEWS

Surface Urban Energy and Water Balance Scheme

https://suews.readthedocs.io/

Mozilla Public License 2.0

12 stars 8 forks source link

QE, QH T2 results lost in certain conditions #209

Closed XiaoxiongXie closed 1 year ago

XiaoxiongXie commented 1 year ago

In some cases QE, QH, T2 outputs are lost (become NaN), i.e. 19 Feb here:

download

Input files: df_state_init_test.csv df_forcing_test.csv

Seems to be a QE issue, but the problem will go if:

using the sample 2012 forcing data
or increasing the QF coefficients (qf_a, b, c), in this case changing qf_c from 0.0012 to 0.0054
or changing net radiation method to 1 (using forcing Ldown), currently 3 (calculated from T and RH)

supy: 2022.4.7 supy_driver: 2021a5

Similar problem is also found in supy 2022.8.5.dev0.

sunt05 commented 1 year ago

Thanks @XiaoxiongXie for reporting this issue.

This could be due to a bug in the porosity calculation leading to negative surface resistance (#197), which has been fixed a recent dev version: pip install supy==2023.7.3.dev0.

Please note there are some changes in the df_state columns - so please update your own df_state by adding the new ones added in the sample data: compare the column names and copy the new ones over to your own.

sunt05 commented 1 year ago

@XiaoxiongXie please close this issue if this has been resolved - otherwise please follow up with more info.