search

UMEP-dev / SuPy

SUEWS that speaks Python
https://supy.readthedocs.io/
GNU General Public License v3.0
13 stars 7 forks source link

Timezone correction for ERA5 #15

Closed ghost closed 1 year ago

ghost commented 3 years ago

@hamidrezaomidvar commented on Jun 15, 2020, 12:19 PM UTC:

Here are my thoughts to correct the forcing data generated using ERA5 for timezone:

Depending on positive or negative time difference, we can modify gen_forcing_era5(...) to change the start or end date (1 day before or after). Then after downloading the files, we change df_forcing variable to correct the time. Specifically, we need to add a function between these lines:

    df_forcing = grp_grid.apply(
        lambda df: format_df_forcing(
            df.reset_index(["latitude", "longitude"], drop=True)
        )
    )

##### Here we need to modify the time of df_forcing

    # save results as SUEWS met input files
    list_fn = save_forcing_era5(df_forcing, dir_save)

This issue was moved by sunt05 from sunt05/SuPy#157.

ghost commented 3 years ago

@sunt05 commented on Jun 15, 2020, 9:25 PM UTC:

df_forcing possibly consists of multiple grids, whence MultiIndex is involved; we may want to modify the format_df_forcing for this correction.

ghost commented 3 years ago

@sunt05 commented on Jun 15, 2020, 9:25 PM UTC:

Anyway, feel free to go ahead with a PR; we can improve the coding there.

github-actions[bot] commented 1 year ago

Stale issue message