search

UMEP-dev / SuPy

SUEWS that speaks Python
https://supy.readthedocs.io/
GNU General Public License v3.0
13 stars 7 forks source link

check_forcing: relax ranges of variables? #23

Closed matthiasdemuzere closed 3 years ago

matthiasdemuzere commented 3 years ago

Describe the Issue I am testing supy over Mexico City, using input from ERA5. When running applying check_forcing, I got this warning: "pres" should be between [800, 1300] but "758.7" is found at 2020-04-30 23:05:00

Perhaps the range should be a bit more relaxed, as such low pressure values might be valid, especially for high-altitude regions?

Moreover, as you can see from the timeseries below, seems that only one timestep is reported, even though the whole time series has pressure values < 800 hPa? Not sure if this behaviour is intended?

Location Referring to the following:

https://github.com/UMEP-dev/SuPy/blob/100d93bedfb2b9d954c479add1ff4b65aa7cd0b9/src/supy/checker_rules_indiv.json#L996-L1004

Screenshots image

Additional context Not applicable

sunt05 commented 3 years ago

Thanks @matthiasdemuzere for reporting this issue. Yes, I fully agree with you that the criteria used in the checking procedure should be improved: the current values were directly borrowed from UMEP; maybe we should determine these more carefully by examination of a broader range of observations.

sunt05 commented 3 years ago

fixed by https://github.com/UMEP-dev/SuPy/commit/d01c8c208d526a623f1683f59796419d52841874