UMEP-dev / UMEP-processing

7 stars 9 forks source link

Morphometric Calculator (grid) gives the same results for all calc.methods #19

Closed DimitrisTsi closed 1 year ago

DimitrisTsi commented 1 year ago

The morphometric calculator (grid) gives the same outputs no matter which calculation method is selected. I am not sure if this is related to the latest update (1.7.12) or goes back to previous versions.

biglimp commented 1 year ago

Thanks. You found a bug that has probably been with us for a long time. I will fix. If you need a quick fix, let me know.

biglimp commented 1 year ago

Fixed. Also fixed so that issues calculating wall area on irregular grid as well as issues when DEM and DSM had different NoData values.

DimitrisTsi commented 1 year ago

Hi! I updated the plugin and i am afraid the issue persists, all outputs are the same regardless of the calculation method. Here are the inputs and outputs for versions 1.7.12 and 1.7.13.

I also quickly tried to replicate the zd (zero-displacement height) output value of the isotropic calculation, using the zH, pai, fai, zStd values and the math that is present in the RoughnessCalc(Roughnessmethod,zH,fai,pai,zMax,zSdev) function of the RoughnessCalcFunctionV2.py script, and could not get the same result that is given in the IMPGrid_isotropic.txt file using any of the methods. The zd value definitely does not match the Rule of Thumb result (which is the default calculation method if the script does not manage to get input from the user if i am not mistaken) for zd which is zd = 0.7*zH.

biglimp commented 1 year ago

I cannot replicate your error. Changing from rule of thumbs and e.g. macDonald gives me different numbers for z0 and zd

DimitrisTsi commented 1 year ago

sorry @biglimp I messed something up during the update, i downloaded the package files again and it works as supposed to, thanks!