search

UMEP-dev / UMEP-processing

7 stars 9 forks source link

Output from SUEWS #2

Closed biglimp closed 3 years ago

biglimp commented 3 years ago

Are these files still valid? I am moving SUEWSAnalyzer over to the UMEP for Processing and I see that these are hard coded. SUEWS_OutputFormatOption1.txt SUEWS_OutputFormatOption2.txt

sunt05 commented 3 years ago

Yes, they are. But as we are using SuPy inside UMEP, I'm wondering if these are still needed and how we may better deal with these.

Can you point me to the code where these files are actually used?

biglimp commented 3 years ago

They are used to prepare the Plugin-interface in SUEWSAnalyzer on which parameters that are available for post-processing and what their units are. https://github.com/UMEP-dev/UMEP/blob/52a0f7ff9c1ac4cc92b48ee14013e8e0c1d9733d/SUEWSAnalyzer/suews_analyzer.py#L290

sunt05 commented 3 years ago

double-checked these files are still valid; but I'm thinking we may use python pickled files for easier post-processing, which can also naturally integrate support for units (thanks to pandas-pint). Let me think how we can more elegantly deal with this.

related: https://github.com/UMEP-dev/SUEWS/issues/158