search

UMEP-dev / UMEP

Urban Multi-scale Environmental Predictor
https://umep-docs.readthedocs.io/
59 stars 15 forks source link

Leafon parameter with southern hemisphere data #441

Closed bweeding closed 1 year ago

bweeding commented 2 years ago

Hi all, was looking to confirm that when a CDSM is loaded into SOLWEIG, it defaults as evergreen/coniferous?

Came across what I believe is a bug in Solweig_v2015_metdata_noload.py:

    leafon1 = 97  #TODO this should change
    leafoff1 = 300  #TODO this should change

Looks like the timings are only for the northern hemisphere?

Cheers Ben

biglimp commented 2 years ago

Hi Ben, Yes, you are correct. This is me being lazy back when I wrote this code. We will try to change this. I the meantime you can change this in the code yourself... /Fredrik

nilswallenberg commented 2 years ago

Hi Ben,

The new fix hopefully works for the southern hemisphere as well. :-)

Cheers, Nils