search

UMEP-dev / UMEP

Urban Multi-scale Environmental Predictor
https://umep-docs.readthedocs.io/
59 stars 15 forks source link

okay I there were missing some values in the tree morphology file. After fixing this it worked! #462

Closed shahjahan0275 closed 1 year ago

shahjahan0275 commented 1 year ago 
    okay I there were missing some values in the tree morphology file. After fixing this it worked!

But now QGIS still craches when using SUEWS advanced even with strongly reduced time period and cell number. The supy log just says '2020-12-22 19:24:54,578 - SuPy - INFO - All cache cleared.'

I will attach my SUEWS prepare results. Would be great if you can at least check weather it works at your side or not.

prepare_klein1.zip

Originally posted by @flgebhardt in https://github.com/UMEP-dev/UMEP/issues/207#issuecomment-749715536

shahjahan0275 commented 1 year ago

I am also facing the same problem with SUEWS prepare. can you please tell me which " values in the tree morphology file" that you have fixed to solve the issue.

biglimp commented 1 year ago

Before we move on, could you please try to run SUEWS from UMEP for processing first and report back the result.

shahjahan0275 commented 1 year ago

I could not prepare the data to run SUEWS using "SUEWS prepare" due to that problem. So how can I run SUEWS from UMEP for processing with out prepared data

shahjahan0275 commented 1 year ago

So I am facing this problem python/plugins\UMEP\SUEWSPrepare\prepare_worker.py, LINE 425 "zH = (float(IMP_heights_mean) LCF_bu + float(IMPveg_heights_mean_eve) LCF_ev + float(IMPveg_heights_mean_dec) * LCF_de) / (LCF_bu + LCF_ev + LCF_de)" ERROR MESSAGE: local variable 'IMPveg_max_dec' referenced before assignment

I am using QGIS 3.26.3 May I know "What are the values that you missed in the tree morphology file" Regards

shahjahan0275 commented 1 year ago

is there any problem in the "prepare_worker.py" to show the error above?

biglimp commented 1 year ago

Ok, now I understand a bit better.

Can you attach your files that you use in SUEWSPrepare and your settings for vegetation, i.e. are you using both deciduous and confier.

shahjahan0275 commented 1 year ago

_build_MPGrid_isotropic.txt _LCFGrid_isotropic.txt _veg_MPGrid_isotropic.txt NYC_2010_UMEP.txt

shahjahan0275 commented 1 year ago

These are the files that I used in SUEWS prepare. I was exactly following this tutorial https://umep-docs.readthedocs.io/projects/tutorial/en/latest/Tutorials/SuewsWUDAPT.html#suewswudapt

biglimp commented 1 year ago

I need your grid also (shapefile).

shahjahan0275 commented 1 year ago

SUEWSWUDAPT_NYC.zip

shahjahan0275 commented 1 year ago

All the grid (shapefile) is in the zip. Regards

biglimp commented 1 year ago

Found the bug. Should be fixed now. It will probably take some time before new version is available in QGIS repo. Use Development Release is you cannot wait.

shahjahan0275 commented 1 year ago

I am facing following problem while running UMEP > Processer > Urban Energy Balance > Urban Energy Balance (SUEWS/BLUEWS, advanced). I am following the same tutorial as before: https://umep-docs.readthedocs.io/projects/tutorial/en/latest/Tutorials/SuewsWUDAPT.html#suewswudapt image

attaching supy log also:

SuPy.log

biglimp commented 1 year ago

What version of UMEP are you using. THis might have been fixed in the latest version.

shahjahan0275 commented 1 year ago

I am using the following version: UMEP Available version (stable) 3.20.7 updated at Tue Oct 11 02:56:13 2022

biglimp commented 1 year ago

Can also please check your version of SuPy. Should be displayed as a log message in QGIS.

biglimp commented 1 year ago

I think I found the issue. Updated to 3.20.8. Install as a development release (https://umep-docs.readthedocs.io/en/latest/Getting_Started.html#installing-development-release-could-be-unstable). You need to go back in the tutorial and re-run SUEWS Prepare.

shahjahan0275 commented 1 year ago

I have followed your instruction. same error: image SuPy.log

biglimp commented 1 year ago

What.version of SuPy do you have?

biglimp commented 1 year ago

Ok, new try. Download latest development release and try again.

shahjahan0275 commented 1 year ago

image I have 32 GB installed memory on my laptop.

biglimp commented 1 year ago

First things first, did we get rid of the other error? This is a new one?

shahjahan0275 commented 1 year ago

Yes, there are no other error, SUEWS ran for quite some time, then this error occurred. Regards

On Tue, 25 Oct 2022, 3:58 pm biglimp, @.***> wrote:

First things first, did we get rid of the other error? This is a new one?

— Reply to this email directly, view it on GitHub https://github.com/UMEP-dev/UMEP/issues/462#issuecomment-1290294298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJKV6L675W245Q4N3PGZWU3WE6VN3ANCNFSM6AAAAAAQ5WIP5A . You are receiving this because you authored the thread.Message ID: @.***>

biglimp commented 1 year ago

@sunt05, what do you make of this last error?

biglimp commented 1 year ago

hm, this error is produced from one of our tutorials which worked before SuPy. We need to find a solution to this.

sunt05 commented 1 year ago

Yes, there are no other error, SUEWS ran for quite some time, then this error occurred. Regards

@shahjahan0275 Thanks for the update - then please close this issue and follow up on the new one.

@biglimp to me, this seems to be an upstream issue as explained in the issue referenced here.