UMEP-dev / UMEP

Urban Multi-scale Environmental Predictor
https://umep-docs.readthedocs.io/
59 stars 15 forks source link

missing trees with Tree Generator #495

Closed simonmarti1992 closed 1 year ago

simonmarti1992 commented 1 year ago

Dear UMEP-users,

I am having a problem using the Tree Generator module to generate CDSM.tif and TDSM.tif layers from a trees.shp layer. I noticed that some trees are missing in the .tif files (see below)

in green the trees position

image

and the resulting CDSM.tif

image

Is there a limitation on the number of trees the Tree Generator can take as input? Sincerely

PS : you'll find attached the data used for this example data.zip

nilswallenberg commented 1 year ago

Hi,

We'll look into it. We need the remaining files for the .shp though (e.g. .dbf, .prj, .shx).

Cheers, Nils

simonmarti1992 commented 1 year ago

Hi, Thank you for your answer. You'll find attached the remaining files Sincerely Simon data.zip

nilswallenberg commented 1 year ago

Thank you!

I had a quick look at your DSM and DEM and they differ where there is supposedly ground surface. For example in bottom center where you don't get trees the DSM have values ~17 and the DEM ~12. Running the tool with the DEM in both Raster DSM and Raster DEM results in a CDSM with trees in all locations.

I would check the DSM and DEM to see if they are correct.

Cheers, Nils

biglimp commented 1 year ago

I am closing this as this seem to be a data issue, not a code issue. Please resubmit if problems does not go away.