UMEP-dev / UMEP

Urban Multi-scale Environmental Predictor
https://umep-docs.readthedocs.io/
GNU General Public License v3.0
62 stars 15 forks source link

QGIS crashes when trying to run SUEWS simple #616

Closed marciaamatias closed 2 weeks ago

marciaamatias commented 6 months ago

Hello

I've said here before I had this problem but I've encountered something that might be useful and that can help you help me, and others.

So, when trying to run the SUEWs model, the SIMPLE version, having all the data, I've tried multiple times to run it and the model makes the QGIS crash. So, the programme completely shuts down. This happens on multiple computers, so the problem is coming from the plugin.

I've tried running it and changing some of the components. The model only Runs if we don't change the height of the meteorological forcing data. When we changed it, the model and QGIS shut down. So if we change the values from 49.600 to any other, it doesn't work.

Obviously, my data was not collected at that height so the value is incorrect for the data I'm using. How can we overcome this?

Capturar

suegrimmond commented 6 months ago

Are you using a comma - (rather than a dot) when you change the height? Needs to be a dot.

marciaamatias commented 6 months ago

I'm using a dot.

I've also tried to use an integer and the same happens

Only works when I leave the 49.600

biglimp commented 6 months ago

I cannot replicate. I changed to 45.6 and could run without any error. What version of QGIS and Python are you running? Go to Help>About. This is what I am using. Make sure that you are not running a session with Python 3.12 but 3.9. We are currently working on making UMEP running under 3.12. Can I also suggest that you download firstaid -plugin. Then we could more easily see what is causing the issues you have.

image

On another note, I found another error when running the model multiple times in the same QGIS session where some files remains open and make the model crash. I will fix that. I will also fix the issue you found when changing file code. Both these issues will be reported in other issues by me.

marciaamatias commented 6 months ago

This is what I'm using and i'm running the model within the UMEP plugin, not on python image

Running with my data but not changing the value for the height it works. If I change it, it crashes image

On my python console C:\Users\marci\AppData\Roaming\Python\Python39\site-packages\supy -0.0009999999999998899 --- Logging error --- Traceback (most recent call last): File "C:\PROGRA~1\QGIS33~1.5\apps\Python39\lib\logging__init__.py", line 1086, in emit stream.write(msg + self.terminator) AttributeError: 'NoneType' object has no attribute 'write' Call stack: File "C:\Users/marci/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\UMEP\UMEP.py", line 445, in SUEWS_simple sg.run() File "C:\Users/marci/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\UMEP\SuewsSimple\suewssimple.py", line 231, in run self.dlg.exec() File "C:\Users/marci/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\UMEP\SuewsSimple\suews_simple.py", line 606, in start_progress suews_wrapper.wrapper(self.model_dir, self.iface, year=YYYY) File "C:\Users/marci/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\UMEP\suewsmodel\suews_wrapper.py", line 59, in wrapper df_state_init = sp.init_supy(path_runcontrol) File "C:\Users\marci\AppData\Roaming\Python\Python39\site-packages\supy_supy_module.py", line 103, in init_supy df_state_init = load_InitialCond_grid_df( File "C:\Users\marci\AppData\Roaming\Python\Python39\site-packages\supy_load.py", line 1809, in load_InitialCond_grid_df logger_supy.info("All cache cleared.") Message: 'All cache cleared.' Arguments: ()

biglimp commented 6 months ago

Then it must be something with your met forcing data. What if you first press "Add settings from test data" and then change forcing height? Then you will use a full year of data from and settings from London. Running the model for only one day as you do is not recommended.

biglimp commented 2 weeks ago

Did you have the same issue with testdata? Can I close this?

marciaamatias commented 2 weeks ago

yes, the same happened. but you can close this.