search

UMICTResearch / resume-me

Application to provide resume and interview feedback
1 stars 1 forks source link

[High] Resume edit should check for lock. #108

Closed sulemandiwan closed 9 years ago

sulemandiwan commented 9 years ago

Update: Resume edit should check to see if resume record's lock variable is set to True. If it is True then that resume has received feedback and as a result is blocked (read-only) from further updates. A new resume should be uploaded now.

Hi @nishanbose I will look into this but I think the lock on the resume will have to be unlocked when an upload is done so this is likely the upload module. But I am keep myself assigned cause I wanted to hear back from you first.

nishanbose commented 9 years ago

This is expected behavior. The resume is not supposed to be unlocked. The feedback will become invalid if the same resume is unlocked. So, the feedback will be valid for the resume and the jobseeker will have to create another resume for feedback

We have discussed this before. I would close this issue.

Best Regards, Nishan Bose MSI Candidate | School of Information University of Michigan LinkedIn http://www.linkedin.com/in/nishanbose/ | Github https://github.com/nishanbose

On Wed, Jul 29, 2015 at 9:29 AM, Suleman Diwan notifications@github.com wrote:

Hi @nishanbose https://github.com/nishanbose I will look into this but I think the lock on the resume will have to be unlocked when an upload is done so this is likely the upload module. But I am keep myself assigned cause I wanted to hear back from you first.

— Reply to this email directly or view it on GitHub https://github.com/UMICTResearch/resume-me/issues/108.

sulemandiwan commented 9 years ago

Okay I will check this out.

The issue

What I am seeing is that when I edit the resume and update it (to upload a new one), the link under feedback points to the new resume but has the old feedback showing under it still. Essentially it is updated/overwritten.

The feedback entries have a link to a specific resume ID so they in theory shouldn't show up unless the same DB entry is updated. But I am going to test this before saying anything with less "should" and more "is".

sulemandiwan commented 9 years ago

Hi Nishan. This is the issue.

nishanbose commented 9 years ago

Fixed. Ready for testing. http://test.review-me.us/

trdillah commented 9 years ago

I'm assigning to Suleman as he raised the issue. It's not clear to me how to test this.