search

UMICTResearch / resume-me

Application to provide resume and interview feedback
1 stars 1 forks source link

Seeker Review, Thank you email, Message Util, Section Name, etc. #192

Closed sulemandiwan closed 9 years ago

sulemandiwan commented 9 years ago

This does not have the Statistics about emails sent, etc. I am working on that. Figuring a couple of things out.

sulemandiwan commented 9 years ago

@trdillah Could you take a look once Nishan has done the code review. Everything works essentially except for the data gathering. Give me a couple of days and I will have it setup nicely.

umichict commented 9 years ago

Sure Suleman but as long as this information is being stored in the database we are ok for this release. Thanks! On Sep 1, 2015 12:37 AM, "Suleman Diwan" notifications@github.com wrote:

@trdillah https://github.com/trdillah Could you take a look once Nishan has done the code review. Everything works essentially except for the data gathering. Give me a couple of days and I will have it setup nicely.

— Reply to this email directly or view it on GitHub https://github.com/UMICTResearch/resume-me/pull/192#issuecomment-136582980 .

nishanbose commented 9 years ago

@sulemandiwan Please add details in the description box. Also, please remove the statements which are not part of this pull request.

I am not entirely clear about "etc." what does that mean?

Also, generally speaking, I would avoid "conversation" type approach when creating pull requests.

umichict commented 9 years ago

Hi Suleman,

Just storing a Boolean variable in the database works for now! The variable isn't being stored at the moment.

Please excuse brevity, sent via mobile. On Sep 1, 2015 12:35 AM, "Suleman Diwan" notifications@github.com wrote:

This does not have the Statistics about emails sent, etc. I am working on

that. Figuring a couple of things out.

You can view, comment on, or merge this pull request online at:

https://github.com/UMICTResearch/resume-me/pull/192 Commit Summary

  • Seeker Review, Thank you email, Message Util, Section Name, etc.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/UMICTResearch/resume-me/pull/192.

nishanbose commented 9 years ago
  1. The "thank you" data should be stored as part of the job seeker feedback to the volunteer
  2. "Rate my feedback" button should be at the end of the feedback section
  3. Move "thank you" to the end of the job seeker feedback (should be the last option)
sulemandiwan commented 9 years ago

Statistical data should not be stored as part of any existing model or be attached to anything other than linked via reference to the account model and vice versa. It is something associated with each account. For this iteration I will add a boolean like @trdillah is saying to the feedback model though.

sulemandiwan commented 9 years ago

Boolean added.

nishanbose commented 9 years ago

@sulemandiwan We are storing all kinds of statistical data in the feedback model. Are you talking about counting number of "Thank Yous"? If so, that should be calculated individually for each feedback.

sulemandiwan commented 9 years ago

Okay all done. Document Inheritance stuff will be worked on tomorrow. Please test. Thanks. :)