search

UMLCloudComputing / UniPath.io

UniPath.io is a full-stack web application that allows users to create, plan, and share their class schedules for their entire degree program.
https://www.unipath.io
MIT License
9 stars 19 forks source link

Google auth fix #111

Closed nbottari9 closed 5 months ago

nbottari9 commented 5 months ago

Overall Review of Changes:

Sign in with google now correctly appears on the login screen

Gurpranked commented 5 months ago

I think there's a missing redirect from the tasks page to the landing page.

rajeshrah22 commented 5 months ago

Your change looks good for this fix but seems like your commits from the darkmode feature are also here. Typically not good practice to mix multiple feature changes in one pull request.

I wonder if you branched off your darkmode feature branch.

Best to branch off main.

github-actions[bot] commented 5 months ago

CI/CD pipeline completed successfully! View branch preview: https://google-auth-fix.d3c5lsis3camij.amplifyapp.com/