search

UMLComputerGraphics / GraphicsProject

UML Graphics 2 Final Project 2013
7 stars 1 forks source link

Lighting Flicker does not work post-lighting enhancements in FinalProject #84

Closed jnsnow closed 11 years ago

jnsnow commented 11 years ago

With the memory issues introduced after the lighting changes fixed, the boost thread no longer appears to control the flicker as it was originally intended to do.

@nickavv are the lights actually getting set?

nuclearmistake commented 11 years ago

fixed. https://github.com/UMLComputerGraphics/GraphicsProject/commit/080cc9dda98176b8ca4c44dd7d9658aa383fb705

zmaybury commented 11 years ago

We're getting weird artifacts we didn't have before the flicker was added back in.

screen shot 2013-05-07 at 4 37 01 pm

nuclearmistake commented 11 years ago

Works great on linux.

The last "fix" for flickering with the new lights caused the light thread to abort immediately, which I repaired and i was observing the lights changing in between different objects, drawing, so i stuck a boost::mutex in there.

I'm currently trying to fix a bug that filled 16 gig of memory in about 20 seconds on the raytracer.

When you find which line of the fix introduced the issue, I might look at it.

nuclearmistake commented 11 years ago

what broje the table?? On Tue, 07 May 2013 16:37:30 -0400, zmaybury notifications@github.com wrote:

We're getting weird artifacts we didn't have before the flicker was added back in.

screen shot 2013-05-07 at 4 37 01 pm

Reply to this email directly or view it on GitHub: https://github.com/UMLComputerGraphics/GraphicsProject/issues/84#issuecomment-17568782

Eric McCann University of Massachusetts, Lowell Department of Computer Science One University Avenue Olsen Hall, Room 304 Lowell, MA 01854 Lab: 978.934.3385 Email: emccann@cs.uml.edu Homepage (lab): www.cs.uml.edu/robots Homepage: www.emccann.net

nuclearmistake commented 11 years ago

The lights flicker. Make a new ticket if a new bug came up.... but I don't see such a bug on linux.