search

UMM-CSci-3601 / intro-to-git

A group exercise practicing with various git ideas and tools
MIT License
2 stars 7 forks source link

Add settings info #61

Closed NicMcPhee closed 3 years ago

NicMcPhee commented 3 years ago

I've installed the Settings App for this organization, and this is a my stab at a settings file that hopefully covers the key settings that we want to set.

I suspect we won't what this does or doesn't do until we actually merge it into master, and we may not really know what happens until we create the assignment in GitHub Classroom to see what happens there.

floogulinc commented 3 years ago

I may have been confused about the "restrict who can push to this branch" option. I found this post pretty helpful: https://github.community/t/best-practices-for-protected-branches/10204

NicMcPhee commented 3 years ago

That link was very helpful – thanks!

I think this is OK to merge? I'd definitely like to see what happens when this setting file is in master.

floogulinc commented 3 years ago

I think for this lab using the settings plugin is more hassle than it's worth. It means faculty will have to edit a file and wait for it to be applied instead of just enabling branch protection in the repo settings. I can see the value of using it to enforce these settings for future labs and iterations but I don't think it's worth using here.

NicMcPhee commented 3 years ago

That seems reasonable. The other idea I thought of is to have two settings files, and then have the faculty copy the relevant file into settings.yml at the relevant moment. Nothing takes effect until there's a commit to main, though, so it's at best a little awkward.

I think what I'll do instead is just write up a short MD file that documents what the faculty member(s) have to do to the settings at the various points.

I'll do that in this PR.