search

UMM-CSci-Systems / Command-line-introduction

An introduction to Unix command line tools
MIT License
0 stars 14 forks source link

GitHub Actions `sample-run` jobs extraneously reference a second argument to students' Bash scripts #25

Open stanislowskij opened 1 month ago

stanislowskij commented 1 month ago

This came up today in class and was seemingly never caught until now – Nic and I had a discussion about it.

In both /.github/workflows/compile_tests.yml and /.github/workflows/clean_tests.yml, there is a job called sample-run which attempts to run students' scripts with two arguments:

         # . . .
34     run: |
35     mkdir sample_run_temp
36     ./big_clean.sh little_dir.tgz sample_run_temp # <-- here
         # . . .

The README clearly specifies that both scripts should only take one argument here and here.

This causes GitHub workflows to fail for seemingly (to students) no reason, if their scripts contain appropriate validation to ensure that the script is only called with 1 argument as intended.

These sample-run jobs should probably just removed entirely, but at the bare minimum, the solution is just to remove this extra argument since it doesn't seem to do anything.