Closed emmahsax closed 6 years ago
@elenam and @floogulinc: Please look over this PR I made as you are able (I'm sure you're all quite busy!). Also, I'm unsure how to run this repo locally.... what system is it using? Grunt? Npm? Jekyll? @floogulinc, how do you run it locally?
Thank you!
To run locally, make sure you have Ruby installed and install Jekyll and Bundler with gem install jekyll bundler
to install Jekyll and Bundler. Then run bundle install
in the root directory of the repo. To start a local webserver that automatically rebuilds the site, run bundle exec jekyll serve
. Then you should have it running at http://localhost:4000/
The reason I had the pagination with outerwindow
and innerwindow
set to 1 was because any more and it starts to wrap to a new line on mobile like this:
I don't really like the pagination this library provides in general and wish it was just a next and previous page button.
The README files do have some information not preserved in the index.md files right now and that is the time each presentation took place. I don't know if that's too important but I was just keeping the README files for reference.
I've built the site and everything is working.
@floogulinc: I can move over all of the information in the READMEs to the index files. I believe the ability to conserve place and time are present.
I agree that the pagination library is not that advanced. Do we want to move it back to 2 for outerwindow and innerwindow? I personally think it looks better on the computer, but I'm up for either.
Just let me know what course of action you want the code to take, and I'll go ahead and do it 😄
@floogulinc: I've moved over all of the rooms/dates/times from the Readme files to the index files, as well as I've added in all of the appropriate breaks in the schedules. I've also verified the page loads locally through jekyll
. Please look over again.
Looks good to me, thanks!
I would be in favor of switching back the pagination settings so it looks better on mobile, I think it's adequate for the majority of users.
Sounds good!
@floogulinc Done!
Everything look good to you @elenam?
To run locally, make sure you have Ruby installed and install Jekyll and Bundler with
gem install jekyll bundler
to install Jekyll and Bundler. Then runbundle install
in the root directory of the repo. To start a local webserver that automatically rebuilds the site, runbundle exec jekyll serve
. Then you should have it running at http://localhost:4000/
This should be in the README for the site.
Looks great to me! Thanks, @emmasax1 for adding the missing info and @floogulinc for help and clarifications!
@elenam @floogulinc It looks like the changes weren't pushed to the site. I believe the pull request has to be Merged instead of Closed. Could someone please reopen the PR and then press the green Merge button?
Thanks!
Yeah, @elenam probably hit "comment and close". I'll merge it.
Thank you!
Yeah, I was under the impression that I was closing the issue, not a PR. Apologies.
What does this pull request do?
README.MD
files in the senior seminar directories, since the code has started to use theindex.md
filesREADME.MD
files to theindex.md
files, consulting past email history announcing the gold star awardsREADME.MD
files to theindex.md
filesseminars.html
for easier readingHow should I test this pull request before merging?
Thank you!