search

UMM-CSci / senior-seminar

Public materials for senior seminar, including assignments, past papers/slides, templates, etc.
https://umm-csci.github.io/senior-seminar/
9 stars 10 forks source link

Clean up code for the Senior Seminars #20

Closed emmahsax closed 5 years ago

emmahsax commented 5 years ago

What does this pull request do?

How should I test this pull request before merging?

Thank you!

emmahsax commented 5 years ago

@elenam and @floogulinc: Please look over this PR I made as you are able (I'm sure you're all quite busy!). Also, I'm unsure how to run this repo locally.... what system is it using? Grunt? Npm? Jekyll? @floogulinc, how do you run it locally?

Thank you!

floogulinc commented 5 years ago

To run locally, make sure you have Ruby installed and install Jekyll and Bundler with gem install jekyll bundler to install Jekyll and Bundler. Then run bundle install in the root directory of the repo. To start a local webserver that automatically rebuilds the site, run bundle exec jekyll serve. Then you should have it running at http://localhost:4000/

floogulinc commented 5 years ago

The reason I had the pagination with outerwindow and innerwindow set to 1 was because any more and it starts to wrap to a new line on mobile like this:

I don't really like the pagination this library provides in general and wish it was just a next and previous page button.

floogulinc commented 5 years ago

The README files do have some information not preserved in the index.md files right now and that is the time each presentation took place. I don't know if that's too important but I was just keeping the README files for reference.

I've built the site and everything is working.

emmahsax commented 5 years ago

@floogulinc: I can move over all of the information in the READMEs to the index files. I believe the ability to conserve place and time are present.

I agree that the pagination library is not that advanced. Do we want to move it back to 2 for outerwindow and innerwindow? I personally think it looks better on the computer, but I'm up for either.

Just let me know what course of action you want the code to take, and I'll go ahead and do it 😄

emmahsax commented 5 years ago

@floogulinc: I've moved over all of the rooms/dates/times from the Readme files to the index files, as well as I've added in all of the appropriate breaks in the schedules. I've also verified the page loads locally through jekyll. Please look over again.

floogulinc commented 5 years ago

Looks good to me, thanks!

I would be in favor of switching back the pagination settings so it looks better on mobile, I think it's adequate for the majority of users.

emmahsax commented 5 years ago

Sounds good!

emmahsax commented 5 years ago

@floogulinc Done!

floogulinc commented 5 years ago

Everything look good to you @elenam?

elenam commented 5 years ago

To run locally, make sure you have Ruby installed and install Jekyll and Bundler with gem install jekyll bundler to install Jekyll and Bundler. Then run bundle install in the root directory of the repo. To start a local webserver that automatically rebuilds the site, run bundle exec jekyll serve. Then you should have it running at http://localhost:4000/

This should be in the README for the site.

elenam commented 5 years ago

Looks great to me! Thanks, @emmasax1 for adding the missing info and @floogulinc for help and clarifications!

emmahsax commented 5 years ago

@elenam @floogulinc It looks like the changes weren't pushed to the site. I believe the pull request has to be Merged instead of Closed. Could someone please reopen the PR and then press the green Merge button?

Thanks!

floogulinc commented 5 years ago

Yeah, @elenam probably hit "comment and close". I'll merge it.

emmahsax commented 5 years ago

Thank you!

elenam commented 5 years ago

Yeah, I was under the impression that I was closing the issue, not a PR. Apologies.