search

UMN-CRFEL / OpenFOAM-Cantera

Interface to couple OpenFOAM and Cantera
GNU General Public License v3.0
34 stars 18 forks source link

This Solver doesnt work #3

Open SnKzm opened 5 months ago

SnKzm commented 5 months ago

I spent quite a bit of time trying to install and use this solver for my research. However, it seems that the developers only shared an erroneous version of their code. When you try to compile the code, you will face several errors that indicate this version is not reliable at all. For example, in the reactingMixtureI.H file, the mixture diffusion function receives four inputs (P, T, Y, rho), as can be seen below:

template inline Foam::PtrList Foam::reactingMixture::D ( const volScalarField& p, const volScalarField& T, const PtrList& Y, const volScalarField& rho ) const

However, when the diffusion function is declared in reactingMixture.H file, it only receives three inputs. See below:

inline PtrList D ( const volScalarField& p, const volScalarField& T, const PtrList& Y ) const;

So, evidently, this version of the code has not been tested before being shared here.

barbariansubhkaran commented 3 months ago

I am facing the same problem.

bialger commented 2 weeks ago

I fixed it by adding to the lst one , const volScalarField& rho

SnKzm commented 2 weeks ago

I fixed it by adding to the lst one , const volScalarField& rho

If I were you I wouldn't continue working on it because we don't know how this sort of modifications will impact the way the code works. If you need to have a solver that incorporates both openfoam and cantera, you can think of other options publicly available like deepflame package.

bialger commented 1 week ago

I fixed it by adding to the lst one , const volScalarField& rho

If I were you I wouldn't continue working on it because we don't know how this sort of modifications will impact the way the code works. If you need to have a solver that incorporates both openfoam and cantera, you can think of other options publicly available like deepflame package.

I know that it will be OK, because this class is written by analogy. But I can agree with you, this solution may be way too bad. Our team is in search of good tools