UMN-CRFEL / OpenFOAM-Cantera

Interface to couple OpenFOAM and Cantera
GNU General Public License v3.0
38 stars 19 forks source link

This code is trash #4

Open bialger opened 2 months ago

bialger commented 2 months ago

OK, guys, I understand that you wanted to add some code to your mediocre paper to make it look better than it is. But what you did is a really bad thing. You made some people believe that this is an actual working solution, while in reality, this is clearly NOT. People spend DAYS trying to make this nonscence work. I strongly recommend anyone who reads this: never consider this repo as something that may help you - just because it would not. You may consider looking on work our team has done with this repo as... some sort of inspiration: https://github.com/EclipseRE/OpenFOAM-EclipseRE

SnKzm commented 11 hours ago

OK, guys, I understand that you wanted to add some code to your mediocre paper to make it look better than it is. But what you did is a really bad thing. You made some people believe that this is an actual working solution, while in reality, this is clearly NOT. People spend DAYS trying to make this nonscence work. I strongly recommend anyone who reads this: never consider this repo as something that may help you - just because it would not. You may consider looking on work our team has done with this repo as... some sort of inspiration: https://github.com/EclipseRE/OpenFOAM-EclipseRE

Hi,

I get what you mean—I also spent a lot of time trying to get this code to work, and find many bugs. It’s good to highlight this here so others can avoid the same issues.

For anyone looking for an alternative, I found a solver called DeepFlame that links Cantera and OpenFOAM. It works well, is regularly updated, and the authors are responsive. Worth checking out!

https://deepflame.deepmodeling.com/en/latest/