search

UMN-LATIS / leaflet-treering

Use link below to test non-released changes.
https://umn-latis.github.io/leaflet-treering/
0 stars 1 forks source link

Bugs when measuring backwards annually. #105

Closed thorn573 closed 3 years ago

thorn573 commented 3 years ago

All issues were remedied so a specimen measured forwards/backwards annually/sub annually presents its data the same way. i.e. meta data banner should display same start & end date.

1) Entering a date in start point popout. Date entered represents the year of the span the next point covers. When measuring backwards annually, entered date must be decreased by one.

2) Meta data banner displaying correct date. When measuring backwards, start year must be increased by 1. If measuring backwards annually, both start and end must be increased by 1. Also, if all data cleared from view data window, meta data banner will reset.

3) View data window display incorrect dates / points not placing correctly Added more cases for point placement.

Tested on Google Chrome & FireFox

cmcfadden commented 3 years ago

looks good!

thorn573 commented 3 years ago

I'm confused. Is that issue in 3 spots or just 1? They are all on the same line, but 2 are in _site/leaf... & 1 is in leaf...

If I fix the issue in leaflet-treering.js, it will fix all of them?

cmcfadden commented 3 years ago

hah sorry I didn't see what was happening there. Just change it in the leaflet-treering file.