search

UMPsychMethodsCore / MethodsCore

All of the projects that the methods core develops, combined into one repository!
7 stars 0 forks source link

made a few comments/fixes #367

Closed mangstad closed 8 years ago

mangstad commented 9 years ago

check the diff for comments in the code.

I still need to at least test FIR auto contrasts after the weekend.

heffjos commented 9 years ago

I've pushed commits that should address your concerns. Specifically, I removed ConditionModifier since it is implicitly built into ConditionName. NaN (case insensitive) can appear in the master data file now. Resample is no longer used and derivatives of regressors are front zero-padded now.

dankessler commented 8 years ago

@heffjos when you say you pushed commits to address the concerns, where did you push them? Do you mean that the issues that @mangstad is solving in this PR are now rolled into the changes in #337?

heffjos commented 8 years ago

@mangstad made comments within the code about design decisions. The commits to address them are in #337. The code he changed regarding ConditionModifier is no longer needed, because we both agreed it is no longer needed since it is implicitly built into the ConditionName variable. This change is also in #337.

dankessler commented 8 years ago

So we can close this pull request without merging, right? Since the edit is no longer required (assuming we accept the other pull request)

mangstad commented 8 years ago

sounds like it.