search

UMPsychMethodsCore / MethodsCore

All of the projects that the methods core develops, combined into one repository!
7 stars 0 forks source link

Conn tool alpha rcw #375

Closed rcwelsh closed 8 years ago

rcwelsh commented 8 years ago

Putting in fixes of the central template from 10 months ago and a small fix on SOM_WriteNII.m for handling NII what are less that 3D and 4D.

dankessler commented 8 years ago

Make sure you check out the issue I put up in #378 as it's motivated by this use case.

In general, I'm reluctant to merge feature branches directly into public, but I can see how our current policy/workflow is perhaps too restrictive when trying to do things the "official" way so we end up taking shortcuts like this.

dankessler commented 8 years ago

On the other hand, this looks like a hotfix, and we've somewhat followed the standards for that.

heffjos commented 8 years ago

+1 the code looks good to me. If we are following the hotfitx procedure, we need to add a tag after the merge, right?

rcwelsh commented 8 years ago

by the way, this pulls in the fix of #368

dankessler commented 8 years ago

I'll merge this and handle the hotfix, and then backport public (with this fix baked in) into ConnTool_alpha (which will soon roll into _beta anyway)