UMSATS / soti

Contains software for the SOTI (Satellite Operations Testing Interface) application, which runs on a NUCLEO-L452 development board.
5 stars 1 forks source link

Add the is_ack flag to serialized message data #24

Open Koloss0 opened 1 month ago

Koloss0 commented 1 month ago

Messages are not currently encoded with the is_ack flag, which is quite useful to know. Update the serialization and deserialization processes to include ACK data. This would affect both the SOTI CLI code, and the STM32 project code.

browo097302 commented 1 month ago

Hi, I was wondering if I could be assigned to this issue and begin working on it. I'm a beginner to open source btw, but I've had a look through what this issue mayinvolve.

I thinking of something along the lines of:

1. Implement ACK Flag in SOTI CLI: Modify the serialization and deserialization processes to include an ACK flag in the messages sent from the soti.py file. Ensure ACK flag indicates whether a message has been received successfully.

2. Go through both stem32 project files: Modify the serializeCANMessage and deserializeCANMessage functions in the STM32 main.c files to handle the new ACK flag. Ensure it can send and receive messages with the ACK flag and correctly process the acknowledgments.

3. Tests: Test the system’s response to both received and not received messages.

4. Update any documentation?

Please let me know if you think I’m on the right track with this approach. I welcome any guidance on specific files I may have missed or additional considerations I should keep in mind while addressing this issue. If there’s a particular approach you would prefer, please don’t hesitate to share your insights.

Cheers

Koloss0 commented 1 month ago

Hi @browo097302. Thank-you for taking interest. However, I will not be able to assign you this task since UMSATS is a student-run organization at the University of Manitoba, and I can only assign tasks to UMSATS members. Sorry to disappoint.

browo097302 commented 1 month ago

Hi, no worries and thanks for confirming that for me