Open Koloss0 opened 2 weeks ago
It might be useful to store the outgoing messages to a .json file as well (which should be simple because the parsing functions can be generalized) so that the full testing session is recorded with timestamps. What do you think?
Ooo. I like your thinking. Yeah, we can record entire sessions, that would be cool. You could then share them with team mates to demonstrate an issue with a component.
I also think if we're gonna use it for this purpose, we should make the formatting easier to read. I think YAML might be a better format over JSON:
{
"time": "10:56:20",
"sender": "CDH",
"recipient": "PLD",
"cmd": "PLD_SET_ACTIVE_ENVS",
"priority": 32,
"body": {
"bitmap": "0b0000000000000000"
}
}
Vs.
- time: '10:56:20'
sender: CDH
recipient: PLD
cmd: PLD_SET_ACTIVE_ENVS
priority: 32
body:
bitmap: 0b0000000000000000
see #35
Right now when you send a command through SOTI, you get feedback like this:
Which is not super helpful. For one, it's formatted in SOTI's internal representation of messages, so it's not even what's being sent over the CAN lines. And second, most people won't even understand how to read it.
For this issue, change the output to:
Feel free to come up with your own suggestions in the comments below.