search

UNC-Libraries / jquery.xmleditor

jQuery based XML editor plugin.
153 stars 71 forks source link

Disallow attribute deletes if use=required #55

Open andreuccio opened 9 years ago

andreuccio commented 9 years ago

Proposed way to not display the (x) if an attribute is required

bbpennel commented 9 years ago

Thank you andreuccio! I am interested to know what your use cases are for wanting to suppress the delete button from attributes, so we can figure out what the best ways to address the issue are.

andreuccio commented 9 years ago

Not sure I understand what you mean by "use cases". Wouldn't you want to suppress the delete button for all required attributes?

vog commented 7 years ago

This pull request is almost 2 years old, despite being well-explained and straight forwardly implemented. What's holding back the merge of this pull request?

bbpennel commented 7 years ago

Apologies, there aren't any issues with the code per say. Mainly this wasn't merged at the time because the editor doesn't perform schema restriction enforcement, it primarily provides assistance. Removing GUI components which limit the users ability to perform work (can't remove element because x number are required, etc) was something we were avoiding until there was a push for a more holistic approach, which hasn't happened. There were also some concerns the behavior might be unexpected since other aspects of required attributes were not implemented (auto-adding required attributes when adding the element, etc). That is why I was trying to find out a bit more about how this change was expected to be used, and then lost track of it.

So I am waffling somewhat on whether to merge this. There isn't much reason to remove a required attribute once it is added, but it would be the only thing treated this way.

vog commented 7 years ago

For reference, this topic has also been discussed in #16.