Closed vog closed 7 years ago
There is a type in SchemaManager.mergeType():
SchemaManager.mergeType()
SchemaManager.prototype.mergeType = function(base, type) { for (var key in type) { if (type.hasOwnProperty(key)) { var value = type[key]; if (value != null && base[key] == null){ base[key] = value; } else if ($.isArray(value) && $.isArray(type[key])){ base[key] = base[key].concat(value); } } } };
The following check is redundant, as value is defined to be type[key].
value
type[key]
} else if ($.isArray(value) && $.isArray(type[key])){
It seems that base[key] is meant instead.
base[key]
I'm not aware of any actual test case that may actually trigger this issue, but better safe than sorry.
There is a type in
SchemaManager.mergeType()
:The following check is redundant, as
value
is defined to betype[key]
.It seems that
base[key]
is meant instead.I'm not aware of any actual test case that may actually trigger this issue, but better safe than sorry.