Closed PatriciaTanzer closed 7 years ago
I have two Jupyter notebooks shared. One is working with the weather data (GSOWeather.ipynb), and the other (LibraryData.ipynb) is working with the library data. Both can be run from within Jupyter. ~The latter has~ Both have been converted to a python script using nbconvert.
As for merging into anything, develop or master, I'm not sure how to designate where it goes via a pull request.
The way I did it was click 'edit' in the pull request, and then change the 'base' to develop instead of master
Sent from my iPhone
On Sep 5, 2017, at 10:07, Brown Biggers notifications@github.com<mailto:notifications@github.com> wrote:
As for merging into anything, develop or master, I'm not sure how to designate where it goes via a pull request.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/UNCG-CSE/Library-Computer-Usage-Analysis/issues/4#issuecomment-327186190, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdqT4tFriVHF1dOA6Xi71MfPPw2T-7auks5sfVWFgaJpZM4PM_P9.
We should probably have something called 'unit test' - it's something that's done in professional development. It's just something that tests for the various functionalities that were intended, as well as passing various values or making requests both with things that should fail and not fail.
To do this, we need to know how we intend our program to be used. Do we intend for it to be only usable from python notebook?
I think all of our assignments need to be submitted as IPython/Jupyter notebooks, but there's nothing that says they need to stay that way. We'll probably need to do some testing to verify that the resultant python scripts work as intended.
Absolutely, everything should be tested.
To that end, I've never used someone else's notebook this way, can you walk me through exactly how you get from your ipynb file to actually running your code?
From: Brown Biggers notifications@github.com Sent: Wednesday, September 6, 2017 8:33:36 AM To: UNCG-CSE/Library-Computer-Usage-Analysis Cc: Patricia Tanzer; Assign Subject: Re: [UNCG-CSE/Library-Computer-Usage-Analysis] Test develop (#4)
I think all of our assignments need to be submitted as IPython/Jupyter notebooks, but there's nothing that says they need to stay that way. We'll probably need to do some testing to verify that the resultant python scripts work as intended.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/UNCG-CSE/Library-Computer-Usage-Analysis/issues/4#issuecomment-327468994, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdqT4kByk_nb9wb8XJ4pwi1au8xoOp3jks5sfpEfgaJpZM4PM_P9.
Perhaps I wasn't clear about the unit test - I don't mean this as something we submit with the final project. It's simply something we write (any language is fine as long as it does what we need) that runs the program and tests every function and way of manipulating data we have. For example, something that runs a set of basic SQL queries on the table of computer usage. Selecting one entry, multiple entries, an entry that doesn't exist, etc. Every time we add something (data or functionality) we also write a test for it. We do that to make sure whatever we add to master isn't going to break what is already there.
We don't submit it with the final project, it's just to make sure that what we have works while we are working on it.
gotcha.
As to how to use Jupyter/IPython notebook, I'd be glad to explain it via chat/email, or I can show you either at my office or before class. What works best for you?
Email is best, I am booked solid from now until 21:00 and then I leave for Chicago in the morning.
On Sep 6, 2017, at 09:04, Brown Biggers notifications@github.com<mailto:notifications@github.com> wrote:
gotcha.
As to how to use Jupyter/IPython notebook, I'd be glad to explain it via chat/email, or I can show you either at my office or before class. What works best for you?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/UNCG-CSE/Library-Computer-Usage-Analysis/issues/4#issuecomment-327476470, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdqT4gDiZyx7aYszKmdBgtbl7iwOhL_hks5sfpg-gaJpZM4PM_P9.
Figure we can close this, and create new issues as we go
We need to test our code in develop before merging into master - master is the gold standard that we really, really, don't want to screw up. Brown, do you have a test program in place? If not, can you respond with how you run your code so that we can look at it?