``Flowable`` name not consistent with other labels

UNEP-Economy-Division / GLAD-ElementaryFlowResources

This is a repository for elementary flow lists, mapping files, and other resources pertinent to the Global LCA Data Access (GLAD) network initiative and data portal. If you want to contribute please contact Jonathas De Mello [jonathas.demello@un.org] and Claudia Giacovelli [claudia.giacovelli@un.org].

https://www.globallcadataaccess.org

26 stars 13 forks source link

``Flowable`` name not consistent with other labels #13

Open cmutel opened 1 year ago

cmutel commented 1 year ago

The the flow list format Flowable is supposed to be The flow name, but this does not match either the other columns (e.g. Flow UUID, not Flowable UUID), or the flow mapping format, which uses FlowName.

Maybe we switch Flowable to FlowName?

cmutel commented 1 year ago

@WesIngwersen I have opened this issue and #12 to fix what seem to me to be minor inconsistencies that make it harder to write correct software to generate or use these formats.

Could you please give some advice on what the process would be to have a public discussion of these issues? Who is the decision maker(s) for this repo?

kshobatake commented 1 year ago

Could you please explain to me what your problems and solutions are? Possibly at the next WG on the 23rd of Jan.

cmutel commented 1 year ago

@kshobatake I think the issue text is clear that we are using both Flow and Flowable, and though consistency is the hobgoblin of little minds, I don't see any reason to have two terms for the same idea.

Could you please send me the invite to the WG? I will attend if possible. You can find my email around :)

cmutel commented 1 year ago

According to one of the presentations, an elementary flow is the combination of flowable, context, and flow unit, and flowable is the same as flow name. This is well explained in the presentation, but not in the mapping format.

The fundamental question raised by this issue is one of consistency.

Why doe we use flowable is we mean flow name? The mapping uses FlowName. If these are indeed the same, we should use one label.
In a similar vein, the mapping format uses FlowName, FlowUUID, FlowContext, but then just Unit. But the unique flow (i.e. FlowUUID) is defined by the name, context, and unit, so this should be FlowUnit.

WesIngwersen commented 1 year ago

OK @cmutel I am OK with these changes to add more consistency.