UNFmontreal / Dcm2Bids

Reorganising NIfTI files from dcm2niix into the Brain Imaging Data Structure
https://UNFmontreal.github.io/Dcm2Bids/
GNU General Public License v3.0
157 stars 82 forks source link

[BF] Auto extractors and merge regex expressions #275

Closed arnaudbore closed 11 months ago

arnaudbore commented 1 year ago

Before this fix, auto_extract_entities was trying to feed all entities found with auto_extractors even if auto_entities was more strict.

Also when providing custom extractors it was overwrote by auto_extractors.

Need some testing, @SamGuay I will send you some data.

codecov-commenter commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (42cd77b) 75.16% compared to head (51af3f9) 75.25%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== + Coverage 75.16% 75.25% +0.09% ========================================== Files 15 15 Lines 1075 1079 +4 Branches 237 239 +2 ========================================== + Hits 808 812 +4 Misses 220 220 Partials 47 47 ``` | [Flag](https://app.codecov.io/gh/UNFmontreal/Dcm2Bids/pull/275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal) | Coverage Δ | | |---|---|---| | [pytest](https://app.codecov.io/gh/UNFmontreal/Dcm2Bids/pull/275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal) | `75.25% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/UNFmontreal/Dcm2Bids/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal) | Coverage Δ | | |---|---|---| | [dcm2bids/sidecar.py](https://app.codecov.io/gh/UNFmontreal/Dcm2Bids/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal#diff-ZGNtMmJpZHMvc2lkZWNhci5weQ==) | `81.13% <100.00%> (+0.11%)` | :arrow_up: | | [dcm2bids/utils/utils.py](https://app.codecov.io/gh/UNFmontreal/Dcm2Bids/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=UNFmontreal#diff-ZGNtMmJpZHMvdXRpbHMvdXRpbHMucHk=) | `84.04% <100.00%> (+0.34%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.