search

UNIwise / socket.io-prometheus-metrics

Socket.IO prometheus metrics exporter written in typescript
Apache License 2.0
36 stars 17 forks source link

socket_io_transmit_bytes counter doesn't change #2

Closed iangregsondev closed 4 years ago

iangregsondev commented 5 years ago

HI,

I have been using your library, works great but there is 1 metrics thats not being updated. Its the

socket_io_transmit_bytes counter

I am emitting things to a room that the client joins. But the counter doesn't increase.

Here is an abstract of what I am getting, as you can see the receive bytes work fine.

Maybe the library isn't listening to room emits ?

Any ideas ?

TYPE socket_io_events_sent_total counter

HELP socket_io_recieve_bytes Total socket.io bytes recieved

TYPE socket_io_recieve_bytes counter

socket_io_recieve_bytes{event="AUTHENTICATE"} 10194516 socket_io_recieve_bytes{event="JOIN_CHANNEL"} 235065 socket_io_recieve_bytes{event="SEND_EXCHANGE_RATES"} 0

HELP socket_io_transmit_bytes Total socket.io bytes transmitted

TYPE socket_io_transmit_bytes counter

naueramant commented 5 years ago

I must admit i haven't tested it with rooms so you might be right about it not listening to room emits. If you have a fix feel free to make a pull request or else i can look into it as soon as i can :).