mva919 commented 7 months ago

What type of PR is this? (Check all that apply)

[ ] ✨feature: Introduces completely new code or new features.
[ ] 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
[ ] ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
[ ] ✅build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
[ ] ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
[ ] 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
[ ] 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
[x] 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

Add testing to dmNotifs and change dmNotifs and nudgeNotifs to make testing easier (Don't kill me taylor 🥺)

Tests

How was this tested?

[x] Unit tests
[ ] Integration tests
[ ] E2E tests
[ ] Manual tests
[ ] Tests were NOT needed
[ ] Other (explain below)

[Optional] Screenshots

Documentation

[ ] Added to README.me
[ ] Seperate document
[x] NO documentation needed

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (89adcb8) to head (770ce9f).

:exclamation: Current head 770ce9f differs from pull request most recent head 5398979. Consider uploading reports for the commit 5398979 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #204 +/- ## =========================================== + Coverage 98.08% 100.00% +1.91% =========================================== Files 28 24 -4 Lines 157 149 -8 Branches 39 33 -6 =========================================== - Hits 154 149 -5 + Misses 3 0 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.