AaronFmyHub commented 7 months ago

What type of PR is this? (Check all that apply)

[x] ✨feature: Introduces completely new code or new features.
[x] 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
[ ] ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
[ ] ✅build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
[x] ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
[ ] 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
[ ] 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
[ ] 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

Added gender to user profile and used that as the default for displaying body model. Also dynamically resize the SVG ViewBox using user device specifications.

Add gender to schema and global context following current method.
Create toggle that is non-indicative.
Use only screen height to limit size of the SVG ViewBox since the ViewBox we are using is always 1-to-2 in terms of width and height. Also protect the bottom part, which contains functional buttons, from being overlapped on.

Tests

How was this tested?

[x] Unit tests
[ ] Integration tests
[ ] E2E tests
[x] Manual tests
[ ] Tests were NOT needed
[ ] Other (explain below)

[Optional] Screenshots

genderSelection.webm

User has PREFERNOTSAY as gender, so use default.

Documentation

[ ] Added to README.me
[ ] Seperate document
[x] NO documentation needed

AI Usage:

Used AI to simplify if-else statement, AI improved run time and readability of my code.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.57%. Comparing base (7c884f2) to head (c537395).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== + Coverage 98.50% 98.57% +0.07% ========================================== Files 32 33 +1 Lines 201 211 +10 Branches 57 59 +2 ========================================== + Hits 198 208 +10 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thienguen commented 6 months ago

good works, run on my machine locally. One thing I do feel iffy is that we currently do not have the pop-up after sign-in asking users what gender they are, this can be a separate issue.

Also, try to sync your branch to the latest main, a lot has been changed,