UNLV-CS472-672 / 2024-S-GROUP3-Barbell

A workout-tracking app with a support website that does more than just track workouts. Cross platform in IOS and Android
4 stars 0 forks source link

173 / Update createNew and startExisting workout pages #223

Closed L-Hen closed 6 months ago

L-Hen commented 7 months ago

Replaced nav bar with newest version. Implemented selection to createNew exercises. Implemented functional search bar. Cleaned up index pages.

What type of PR is this? (Check all that apply)

Description

What did you change? How did you change it? Implemented functionality to "start new exercise" page.

Tests

How was this tested?

[Optional] Screenshots

Documentation

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

Still need functionality Filter by equipment (Button) Use Diagram (Button) Send array of exercises selected to following page. Start Freeform Workout (Button)

AI Conversation

https://chat.openai.com/share/76270bd9-7a89-4f77-bc9e-91989a8c81b6 https://chat.openai.com/share/a8f2901b-98de-4349-9745-12f79a947e8e Used AI to generate code and clarify structure.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.61%. Comparing base (20ced96) to head (fdb0878). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #223 +/- ## ======================================= Coverage 98.61% 98.61% ======================================= Files 34 34 Lines 217 217 Branches 63 63 ======================================= Hits 214 214 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thienguen commented 6 months ago

reviewing now

AaronFmyHub commented 6 months ago

I got a warning say add unique "Key" Prop, but a warning is a warning

thienguen commented 6 months ago

@mva919 Please suggest your changes to the layout of this page

L-Hen commented 6 months ago

Addressed comments, ready for re-review

thienguen commented 6 months ago

Addressed comments, ready for re-review

re-review by tonight

thienguen commented 6 months ago

image

Like I said below, this one could need some more details but I'm happy with this :>

if you can, the next issue could fix the indentation a bit to match the back button, the search icon and the filter button

image

thienguen commented 6 months ago

the above was fine,

but could have some padding so it doesn't stick to the rear too much like what you did to the other page

image

good work implementing the taylor navbar