search

UNLV-CS472-672 / 2024-S-GROUP3-Barbell

A workout-tracking app with a support website that does more than just track workouts. Cross platform in IOS and Android
4 stars 0 forks source link

Frontend - Contact Us Screen #229

Closed StefanoRubini closed 5 months ago

StefanoRubini commented 5 months ago

What type of PR is this? (Check all that apply)

Description

What did you change? How did you change it?

This PR adds a "Contact Us" page, whose purpose is to display useful contact information on how to reach out to the people behind Barbell. For the moment, the contact information is generic until legitimate contact methods are created.

Tests

How was this tested?

[Optional] Screenshots

https://github.com/UNLV-CS472-672/2024-S-GROUP3-Barbell/assets/124111831/c7afc5c9-be7e-4fe6-8984-03b1a7b98831

Documentation

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

No

Usage of AI

For this specific task, I used ChatGPT to answer some questions that I had in regards to the various methods of styling that exist when using TypeScript code. I was a bit confused on what styling was in regards to className, inline and Tailwind CSS styling, but ChatGPT was able to answer my questions and apply necessary styling changes to the Contact Us page.

Link to ChatGPT conversation: https://chat.openai.com/share/5e4a70ec-4936-4500-9821-d89ec43df531

Additional Notes

Closes Issue #154

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.23%. Comparing base (e80f0f6) to head (d615a8b).

:exclamation: Current head d615a8b differs from pull request most recent head e27306d. Consider uploading reports for the commit e27306d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #229 +/- ## =========================================== - Coverage 99.41% 77.23% -22.18% =========================================== Files 40 29 -11 Lines 340 246 -94 Branches 63 81 +18 =========================================== - Hits 338 190 -148 - Misses 2 56 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StefanoRubini commented 5 months ago

Hello Miguel! Thank you so much for taking the time to look over my PR and to give me useful feedback onto how I can improve the Contact Us screen. I will move forward with your suggestions and implement them in my future iteration of my PR, thank you! 😃

L-Hen commented 5 months ago

image lowkey (highkey) would delete this

thienguen commented 5 months ago

Added henry as one of the reviewers

StefanoRubini commented 5 months ago

For the most recent iteration of this PR, here is some information:

  1. I have simplified some of the styling by using const variables, viewStyles and textStyles, to make the main code easier to read.
  2. I tried to use TailwindCSS, but the styling was not coming out like I wanted (I wanted to maintain the original page appearance).
  3. I decided to keep the little message at the bottom of the screen, because removing it would make the page feel too empty. I also centered the text to make it more visually appealing.
  4. I used a SafeAreaView in order to add some more padding from the top, but I noticed that it had no effect on this specific portion of the header: Screenshot 2024-04-21 at 5 25 49 PM

So maybe it has something to do with the white navigation header just being goofy, but its good to have SafeAreaView nonetheless.

L-Hen commented 5 months ago

Good work! Approving changes.