UNLV-CS472-672 / 2024-S-GROUP3-Barbell

A workout-tracking app with a support website that does more than just track workouts. Cross platform in IOS and Android
4 stars 0 forks source link

New post and post feed #232

Closed elliotwesoff closed 5 months ago

elliotwesoff commented 5 months ago

What type of PR is this? (Check all that apply)

Description

Created the "New Post" component. Connected it with the existing createPost endpoint in the post router. Posts create successfully and are linked to the currently logged in user. The user is redirected to the root route on successful post creation. Resolves #197.

Tests

How was this tested?

[Optional] Screenshots

2024-04-21_13-29 2024-04-21_13-29_1 2024-04-21_13-30 2024-04-21_13-30_1

Documentation

thienguen commented 5 months ago

hmm,I don't like the box wrapped around to input like that, since our app is more on a darker theme, and rounded corner in this case sucks (in game)

image

can we make the text input be like a single underline, and input that way?

Also, add some padding horizontally. Its taking an uncomfortable amount of spaces near the rear to my comfort lol

elliotwesoff commented 5 months ago

@thienguen for some reason I can't reply directly to your comment. Where would you like the padding? On the input? Do you mean margin instead?

thienguen commented 5 months ago

@thienguen for some reason I can't reply directly to your comment. Where would you like the padding? On the input? Do you mean margin instead?

either margin or padding on the x-axis, but if only you changes to underlined input prompt lile i sent the image above, if not then it might not be the biggest problem

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.23%. Comparing base (20ced96) to head (b432251). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## =========================================== - Coverage 98.61% 77.23% -21.39% =========================================== Files 34 29 -5 Lines 217 246 +29 Branches 63 81 +18 =========================================== - Hits 214 190 -24 - Misses 3 56 +53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thienguen commented 5 months ago

well, I can have another look by tonight

StefanoRubini commented 5 months ago

Hello Elliot! Your design layout for new post and post feed look good to me, I appreciate the simple design that you have created. Everything looks splendid to me! 😃