thienguen commented 5 months ago

What type of PR is this? (Check all that apply)

[x] ✨feature: Introduces completely new code or new features.
[x] 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
[ ] ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
[x] ✅build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
[ ] ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
[ ] 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
[ ] 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
[ ] 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

What did you change? How did you change it?

I got cooked in the backend, pretty pretty pretty rough
integrate trpc websocket in our db, having it ready in localhost
(blocker) couldn't test in deployment, since this is still in local host, I will be hosting it on my personal account of this repository (fork) and then go from there
All our procedures currently reside in https://trpc.io/docs/subscriptions.
I will address this as a "advanced feature" in my next issue.
create 2 testing environment for websocket, however, you should be focusing on the mobile environment.
both API handler now resides in api.tsx respectively
fixed pnpm run vitest
fixed migration
fixed packages versions (all fixed see commits history)
Separate context instances in trpc.ts (now we know its either in nextjs or in expo again)

Tests

How was this tested?

Run like normal, invoke both the website (we treat it as a server here) and invoke the mobile app. Follow the instruction with screenshots down below

[ ] Unit tests
[x] Integration tests
[ ] E2E tests
[x] Manual tests
[ ] Tests were NOT needed
[ ] Other (explain below)

[Optional] Screenshots

Have at least 2 instances of virtual devices running (WE USING EXPO GO WITH THIS, but if you can open the app on 2 devices using development build, feel free to do so)
In the 1st terminal (the website / "server") you should see

I'm running 3 virtual devices, aka 3 connections has established
Navigate to nav --> post2

type through the keyboard, and you should see T is typein (this is hard code)

Submit something, should also show in different devices since you can assume this test environment is their dedicated "room"

I CAN'T RECORD THE ENTIRE SCREEN SINCE THE DEVICE KEEP TAKING THE FOCUS.

https://github.com/UNLV-CS472-672/2024-S-GROUP3-Barbell/assets/94078395/0a5b8cb1-0240-47d6-9380-4c1b7135f64b

Documentation

[x] Added to README.me
[ ] Separate document
[ ] NO documentation needed

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

TBD, will write how to test after the break...but I won't be writing more, though I do have a couple of stuff I want to organize in our repo

Update: n/a (will brought up in our meeting)

Update: (after talking to marcos) I can't test on deployment unless this code is in main (so I can sync and make it a "production", organization so nothing I can do (in a short time)

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.61%. Comparing base (20ced96) to head (aacd48a). Report is 4 commits behind head on main.

:exclamation: Current head aacd48a differs from pull request most recent head bba94a7. Consider uploading reports for the commit bba94a7 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #240 +/- ## ======================================= Coverage 98.61% 98.61% ======================================= Files 34 34 Lines 217 217 Branches 63 63 ======================================= Hits 214 214 Misses 3 3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.