thienguen commented 6 months ago

What type of PR is this? (Check all that apply)

[ ] ✨feature: Introduces completely new code or new features.
[x] 🐛fix: Implements changes that fix a bug. Ideally, reference an issue if present.
[ ] ♻️refactor: Includes any code-related change that is neither a fix nor a feature.
[x] ✅build: Encompasses all changes related to the build of the software, including changes to dependencies or the addition of new ones.
[x] ⚡️test: Pertains to all changes regarding tests, whether adding new tests or modifying existing ones.
[x] 🚰ci: Involves all changes related to the configuration of continuous integration, such as GitHub Actions or other CI systems.
[ ] 📚docs: Includes all changes to documentation, such as README files, or any other documentation present in the repository.
[ ] 🗑️chore: Captures all changes to the repository that do not fit into the above categories.

Description

What did you change? How did you change it?

Fix some of the bugs found in main (API changes due to schema proposal)
Fix some basic logic of API
Write all unit tests for existing backend API called
du du du du
move all test file in expo to __tests___
write more tests on them
we reaching 95++% with this one 🗣️

Tests

How was this tested?

[x] Unit tests
[x] Integration tests
[ ] E2E tests
[ ] Manual tests
[ ] Tests were NOT needed
[ ] Other (explain below)

[Optional] Screenshots

Check out this branch
cd apps/expo
pnpm run jest

at root
cd packages/api
pnpm run vitest

pnpm run vitest-ui
enjoy

Documentation

[ ] Added to README.me
[ ] Seperate document
[ ] NO documentation needed

Link to external documentation:

[Optional] Are there any post-deployment tasks we need to perform?

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.40%. Comparing base (0544743) to head (28c393c).

Files	Patch %	Lines
packages/api/src/router/friend.router.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #247 +/- ## =========================================== + Coverage 77.23% 99.40% +22.17% =========================================== Files 29 40 +11 Lines 246 338 +92 Branches 81 61 -20 =========================================== + Hits 190 336 +146 + Misses 56 2 -54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.